RE: [PATCH] mtd: fsl_elbc_nand: set NAND_NO_SUBPAGE_WRITE flag if using hardware ECC

[Gupta, Pekon]

Hi Nikita,

>From: Nikita Yushchenko
>
>Per MPC8572E manual, sec 14.4.3.1.3: "Transfers shorter than a full page,
>however, require software to prepare the appropriate ECC in the spare
>region"
>
>Need to set NAND_NO_SUBPAGE_WRITE flag. If this is not done, then
>generic nand_write_subpage_hwecc() is called instead of driver's
>write routine, which results into OOPS dereferencing NULL chip->ecc.hwctl
>pointer.
>
>Signed-off-by: Nikita Yushchenko <nyushchenko@xxxxxxxxxxxxx>
>---

This one is already solved.

Please refer below discussion and its previous thread on
why NAND_NO_SUBPAGE_WRITE should _not_ be set,
because it breaks compatibility with older UBIFS images.

http://lists.infradead.org/pipermail/linux-mtd/2014-April/053262.html

Also below is the appropriate fix without breaking backward compatibility.
http://lists.infradead.org/pipermail/linux-mtd/2014-May/053745.html


with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/