Re: [PATCH 02/27] ACPICA: Utilities: Deploy ACPI_DEBUGGER_EXEC for ACPI_DEBUGGER enabled code in utglobal.c.

[Pavel Machek]

Hi!

> > From: Pavel Machek [mailto:pavel@xxxxxx]
> > Sent: Tuesday, May 06, 2014 3:54 PM
> > 
> > On Wed 2014-04-30 10:03:39, Lv Zheng wrote:
> > > This patch deploys ACPI_DEBUGGER_EXEC usage to utglobal.c to reduce "ifdef"
> > > of ACPI_DEBUGGER.  No functional changes.  Lv Zheng.
> > >
> > > Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx>
> > > Signed-off-by: Bob Moore <robert.moore@xxxxxxxxx>
> > > ---
> > >  drivers/acpi/acpica/utglobal.c |    4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/acpi/acpica/utglobal.c b/drivers/acpi/acpica/utglobal.c
> > > index f3abeae..825b064 100644
> > > --- a/drivers/acpi/acpica/utglobal.c
> > > +++ b/drivers/acpi/acpica/utglobal.c
> > > @@ -377,9 +377,7 @@ acpi_status acpi_ut_init_globals(void)
> > >  	acpi_gbl_disable_mem_tracking = FALSE;
> > >  #endif
> > >
> > > -#ifdef ACPI_DEBUGGER
> > > -	acpi_gbl_db_terminate_threads = FALSE;
> > > -#endif
> > > +	ACPI_DEBUGGER_EXEC(acpi_gbl_db_terminate_threads = FALSE);
> > >
> > >  	return_ACPI_STATUS(AE_OK);
> > 
> > Is it just me or is this incredibly ugly?
> 
> This patch is no-op for Linux kernel.
> ACPI_DEBUGGER is not enabled for Linux kernel.
> 
> This patch is here to reduce the source code differences between
> Linux and ACPICA.

> ACPICA release is done by a set of conversion utilities, the process is known as linuxizing.
> The generation result of the linuxizing will require more human
> interventions if such differences grow bigger.

You don't have to do the change to the original ACPICA release, do
you?

Would it be feasible to modify your linuxizing scripts to simply
delete #ifdefs that can not happen for linux?
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/