Re: [PATCH] clk: st: Fix memory leak

[Gabriel Fernandez]

Hi Valentin
Thanks for the patch, i agree with it.

Mike do you planned to integrate this patch ?

Gabriel.

Best Regards.


On 05/06/2014 11:29 AM, Valentin Ilie wrote:
> On 22 April 2014 16:15, Valentin Ilie <valentin.ilie@xxxxxxxxx> wrote:
> > When it fails to allocate div, gate should be free'd before return
> >
> > Signed-off-by: Valentin Ilie <valentin.ilie@xxxxxxxxx>
> > ---
> >   drivers/clk/st/clkgen-pll.c | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
> > index bca0a0b..a886702 100644
> > --- a/drivers/clk/st/clkgen-pll.c
> > +++ b/drivers/clk/st/clkgen-pll.c
> > @@ -521,8 +521,10 @@ static struct clk * __init clkgen_odf_register(const char *parent_name,
> >          gate->lock = odf_lock;
> >
> >          div = kzalloc(sizeof(*div), GFP_KERNEL);
> > -       if (!div)
> > +       if (!div) {
> > +               kfree(gate);
> >                  return ERR_PTR(-ENOMEM);
> > +       }
> >
> >          div->flags = CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO;
> >          div->reg = reg + pll_data->odf[odf].offset;
> > --
> > 1.8.3.2
> Can someone look into this?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/