Re: [PATCH v2] w1: do not unlock unheld list_mutex in __w1_remove_master_device()

From: zbr
Date: Tue May 06 2014 - 19:57:42 EST


Hi everyone

07.05.2014, 03:49, "David Fries" <David@xxxxxxxxx>:
> Acked-by: David Fries <david@xxxxxxxxx>
>
> On Wed, May 07, 2014 at 01:26:04AM +0400, Alexey Khoroshilov wrote:
>
>>  w1_process_callbacks() expects to be called with dev->list_mutex held,
>>  but it is the fact only in w1_process(). __w1_remove_master_device()
>>  calls w1_process_callbacks() after it releases list_mutex.
>>
>>  The patch fixes __w1_remove_master_device() to acquire list_mutex
>>  for w1_process_callbacks().
>>
>>  Found by Linux Driver Verification project (linuxtesting.org).
>>
>>  Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>

Thanks for this fix
Acked-by: Evgeniy Polyakov <zbr@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/