Re: [PATCH v3] x86/iosf: Make IOSF driver modular and usable by more drivers

[One Thousand Gnomes]

> I guess I don't see why the module isn't removable.  Of course, any
> driver which calls iosf_mbi_available() will depend on it, preventing
> removal until *those* modules have been removed...

Going back over the current version you could unload it but you rely upon
the iosf_mbi_available caller locking the module in memory (which I think
is fair) and someone not forcing a hot unplug of any kind from userspace,
in which case life gets a bit odd as we clear mbi_pdev in the exit method
not when the device is unplugged. Probably for the best as with a remove
method you'd need to check the mbi_pdev pointer inside iosf_mbi_lock and
also clear it under the lock.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/