Re: [PATCH 3/4] of/platform: fix device naming for non-translatable addresses

From: Arnd Bergmann
Date: Thu May 08 2014 - 06:41:34 EST


On Wednesday 07 May 2014 16:48:17 Rob Herring wrote:
> From: Rob Herring <robh@xxxxxxxxxx>
>
> Using non-translatable addresses in platform device names is wrong
> because they may not be globally unique. Just use the default naming with
> a global index if the address cannot be translated instead.
>
> of_can_translate_address has the same checks as of_translate_address, so
> we can remove it here as well.

Have you checked that this doesn't break platforms using clkdev lookup
based on names with local addresses? It's quite possible that nobody
does that, but it would be good to have someone confirm it.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/