Re: [PATCH] usb: gadget: gr_udc: unconditionally use GFP_ATOMIC in gr_queue_ext()

[Andreas Larsson]

On 2014-05-07 22:26, Alexey Khoroshilov wrote:
> As far as gr_queue() is called with spinlock held,
> we have to pass GFP_ATOMIC regardless of gfp argument.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>

Acked-by: Andreas Larsson <andreas@xxxxxxxxxxx>

> ---
>   drivers/usb/gadget/gr_udc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/gr_udc.c b/drivers/usb/gadget/gr_udc.c
> index f984ee75324d..19a1b52c4210 100644
> --- a/drivers/usb/gadget/gr_udc.c
> +++ b/drivers/usb/gadget/gr_udc.c
> @@ -1679,7 +1679,7 @@ static int gr_queue_ext(struct usb_ep *_ep, struct usb_request *_req,
>   	if (ep->is_in)
>   		gr_dbgprint_request("EXTERN", ep, req);
>
> -	ret = gr_queue(ep, req, gfp_flags);
> +	ret = gr_queue(ep, req, GFP_ATOMIC);
>
>   	spin_unlock(&ep->dev->lock);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/