Re: [PATCH] blk-mq: initialize struct request fields individually

From: Jens Axboe
Date: Thu May 08 2014 - 16:53:15 EST


On 05/06/2014 04:12 AM, Christoph Hellwig wrote:
> This allows us to avoid a non-atomic memset over ->atomic_flags as well
> as killing lots of duplicate initializations.

I had an earlier variant of this as well, they are quite a few fields we
can neglect to initialize. But I think this is a safe start, however,
and we can always optimize it on top of it. Perhaps even start to
separate struct request a bit, so we can safely memset parts of it easily.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/