Re: [PATCH 1/3] staging: cxt1e1: Fix no spaces at the start of a line in musycc.c

[Dan Carpenter]

On Fri, May 09, 2014 at 05:22:18PM +0900, DaeSeok Youn wrote:
> 2014-05-09 16:59 GMT+09:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
> > On Fri, May 09, 2014 at 10:38:43AM +0900, Daeseok Youn wrote:
> >> clean up checkpatch.pl warning:
> >>  WARNING: please no spaces at the start of a line in
> >>
> >> Signed-off-by: Daeseok Youn <daeseok.youn@xxxxxxxxx>
> >> ---
> >> This patch includes cleanup for fixing line length.
> >>
> >
> > This patch is super hard to review.  Your "line length" fixes include
> > moving variable declarations around, deleting comments, getting rid of
> > nonsense curly braces.  Those are all great but the patch is over a
> > thousand lines long and it's difficult to review.
> Yes.. I knew that. And sorry about that. but I was really hard to
> separate this patch for
> fixing coding style. :-(
> When I replaced spaces with tabs, it has too many tabs so I cannot leave
>  that lines on this patch.(and removed curly braces can solve my concern..)
> But I should do as your comment.

Yeah.  I know that it means we go over the 80 character limit.  Don't
stress about that.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/