Re: [PATCH 11/20] arch,m68k: Fold atomic_ops

[Geert Uytterhoeven]

Hi Peter,

On Thu, May 8, 2014 at 3:58 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> +#ifdef CONFIG_RMW_INSNS
>
> -static inline void atomic_sub(int i, atomic_t *v)
> -{
> -       __asm__ __volatile__("subl %1,%0" : "+m" (*v) : ASM_DI (i));
> -}
> +#define ATOMIC_OP(op, c_op, asm_op)                                    \
> +static inline void atomic_##op(int i, atomic_t *v)                     \
> +{                                                                      \
> +       __asm__ __volatile__(#asm_op "l %1,%0" : "+m" (*v) : ASM_DI (i));\
> +}                                                                      \

> +#else
> +
> +#define ATOMIC_OP(op, c_op, asm_op)                                    \
> +static inline void atomic_##op(int i, atomic_t *v)                     \
> +{                                                                      \
> +       __asm__ __volatile__(#asm_op "l %1,%0" : "+m" (*v) : ASM_DI (i));\
> +}                                                                      \

These two chunks are identical, so please move them out of the #ifdef.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/