Re: [PATCH 11/20] arch,m68k: Fold atomic_ops

From: Geert Uytterhoeven
Date: Fri May 09 2014 - 05:44:21 EST


On Fri, May 9, 2014 at 11:16 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Fri, May 09, 2014 at 11:08:37AM +0200, Geert Uytterhoeven wrote:
>> These two chunks are identical, so please move them out of the #ifdef.
>
> More lines saved!
>
> ---
> Subject: arch,m68k: Fold atomic_ops
> From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Date: Sun Mar 23 19:06:34 CET 2014
>
> Many of the atomic op implementations are the same except for one
> instruction; fold the lot into a few CPP macros and reduce LoC.
>
> This also prepares for easy addition of new ops.
>
> Requires asm_op due to eor.
>
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>

Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/