Re: [PATCH 2/4] sched,numa: weigh nearby nodes for task placement on complex NUMA topologies

From: Peter Zijlstra
Date: Fri May 09 2014 - 06:13:31 EST


On Thu, May 08, 2014 at 01:23:29PM -0400, riel@xxxxxxxxxx wrote:
> This patch does nothing on machines with simple NUMA topologies.

Was this:

> + /*
> + * No need to calculate a score if the system has a simple NUMA
> + * topology, with no node distances between "local" and "far away".
> + */
> + if (max_distance == LOCAL_DISTANCE)
> + return 0;

Supposed to make that true?

It doesn't. That test is a !numa test, not a fully connected test.

Attachment: pgpDUajcWAS_C.pgp
Description: PGP signature