Re: [PATCH 2/5] staging: cxt1e1: remove dead code in musycc.c

[Dan Carpenter]

On Fri, May 09, 2014 at 07:06:06PM +0900, Daeseok Youn wrote:
> Removes "#if 0" blocks.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@xxxxxxxxx>
> ---
> Dan,
>  I decided to leave musycc_dump_rxbuffer_ring(ch, 0) which is commented
>  out and make a block as "RLD_DEBUG". Because i think this block need to debug
>  with define "RLD_DEBUG". If I am wrong, let me know.
> 

This change should maybe have been in a separate patch.  It's a border
line thing.  But definitely, it should have been mentioned in the
changelog.

Btw, you can use `git citool` to add or remove lines from a
commit.  Highlight and right click on the lines you want to add or
remove.

I don't really care either way if you keep it or delete it.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/