Re: [PATCH] mm: use a irq-safe __mod_zone_page_state in mlocked_vma_newpage()

[Christoph Lameter]

On Fri, 9 May 2014, Jianyu Zhan wrote:

> mlocked_vma_newpage() is only called in fault path by
> page_add_new_anon_rmap(), which is called on a *new* page.
> And such page is initially only visible via the pagetables, and the
> pte is locked while calling page_add_new_anon_rmap(), so we could use
> a irq-safe version of __mod_zone_page_state() here.

You are changing from the irq safe variant to __mod_zone_page_state which
is *not* irq safe. Its legit to do so since presumably irqs are disabled
anyways so you do not have to worry about irq safeness of
__mod_zone_page_state.

Please update the description. Its a bit confusing right now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/