Re: [PATCH] ARM: dts: am335x-bone-common: Add i2c2 definition

[Matt Ranostay]

On Fri, May 9, 2014 at 5:57 AM, Nishanth Menon <nm@xxxxxx> wrote:
> On Fri 09 May 2014 12:56:23 AM CDT, Matt Ranostay wrote:
>> Add missing i2c2 bus define to access various cape and
>> prototype/breakout board devices.
>>
>> Signed-off-by: Matt Ranostay <mranostay@xxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/am335x-bone-common.dtsi | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
>> index 2e7d932..2aedfee 100644
>> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
>> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
>> @@ -84,6 +84,13 @@
>>               >;
>>       };
>>
>> +     i2c2_pins: pinmux_i2c2_pins {
>> +             pinctrl-single,pins = <
>> +                     0x178 (PIN_INPUT_PULLUP | MUX_MODE3)    /* i2c2_sda.uart1_ctsn */
>> +                     0x17c (PIN_INPUT_PULLUP | MUX_MODE3)    /* i2c2_scl.uart1_rtsn */
>
> I dont understand the comment -> i2c2_sda is being muxed to uart1_cstsn?
>
Good catch I mixed up the ordering of the comment.

>> +             >;
>> +     };
>> +
>>       uart0_pins: pinmux_uart0_pins {
>>               pinctrl-single,pins = <
>>                       0x170 (PIN_INPUT_PULLUP | MUX_MODE0)    /* uart0_rxd.uart0_rxd */
>> @@ -222,6 +229,15 @@
>>
>>  };
>>
>> +
>> +&i2c2 {
>> +     pinctrl-names = "default";
>> +     pinctrl-0 = <&i2c2_pins>;
>> +
>> +     status = "okay";
>> +     clock-frequency = <400000>;
>
> How did we decide on 400KHz -> do all all i2c2 devices on ALL capes
> work in full speed? OR should we consider a conservative 100KHz?
>

Probably a better plan.
Will submit v2 this weekend.

>> +};
>> +
>>  /include/ "tps65217.dtsi"
>>
>>  &tps {
>
>
> --
> Regards,
> Nishanth Menon
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/