Re: [PATCH] sched: wake up task on prev_cpu if not in SD_WAKE_AFFINE domain with cpu

[Rik van Riel]

On 05/09/2014 01:55 PM, Mike Galbraith wrote:
> On Fri, 2014-05-09 at 11:24 -0400, Rik van Riel wrote:
> > On 05/09/2014 11:24 AM, Mike Galbraith wrote:
>
> > > If no ->flags & SD_BALANCE_WAKE is encountered during traversal, sd
> > > remains NULL, we fall through to return prev_cpu.
>      ^^^^^^^^^^^^
>
> > We do fall through, but into this loop:
>
> >           while (sd) {

You are right. That code is a little hard to follow...

That leaves the big question: do we want to fall back to
prev_cpu if it is not idle, and it has an idle sibling,
or would it be better to find an idle sibling of prev_cpu
when we wake up a task?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/