Re: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM

[Thor Thayer]

On Thu, May 8, 2014 at 5:44 PM, Dinh Nguyen <dinh.linux@xxxxxxxxx> wrote:
>
> On 5/5/14 5:52 PM, tthayer@xxxxxxxxxx wrote:
>> From: Thor Thayer <tthayer@xxxxxxxxxx>
>>
>> ---
>> v2: Use the SDRAM controller registers to calculate memory size
>>     instead of the Device Tree. Update To & Cc list. Add maintainer
>>     information.

<snip>

>> +
>> +err2er altr_sdram_edac_driver = {
>> +     .probe = altr_sdram_probe,
>> +     .remove = altr_sdram_remove,
>> +     .driver = {
>> +             .name = "altr_sdram_edac",
>> +             .of_match_table = of_match_ptr(altr_sdram_ctrl_of_match),
> I don't think you need of_match_ptr here for this platform as SOCFPGA is
> only a DT platform. All that of_match_ptr() does for a CONFIG_OF platform
> is just return the pointer.
>
> Dinh

Thanks Dinh. I'll remove it in my next submission.

>> +     },
>> +};
>> +
>> +module_platform_driver(altr_sdram_edac_driver);
>> +
>> +MODULE_LICENSE("GPL v2");
>> +MODULE_AUTHOR("Altera Corporation");
>> +MODULE_DESCRIPTION("EDAC Driver for Altera SDRAM Controller");
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/