Re: [PATCH] checkpatch: Warn on #defines ending in semicolon

From: Joe Perches
Date: Fri May 09 2014 - 18:01:15 EST


On Fri, 2014-05-09 at 23:47 +0200, Thomas Gleixner wrote:
> On Fri, 9 May 2014, Joe Perches wrote:
>
> > Using a #define ending in a semicolon is poor style
>
> It's not poor style it's simply a bug. Just because it
>
> > can lead to unexpected code paths being executed.

I think it's still a (bad) style issue.

I remember a discussion with a developer that
wanted all macros to end in a semicolon so he
could write COBOL like C.

ick.

cheers, Joe


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/