Re: [PATCH 1/1 RESEND] drivers/scsi/sd.c: remove positive test on unsigned value

[James Bottomley]

On Sat, 2014-05-10 at 12:49 +0200, Fabian Frederick wrote:
> val is unsigned.

Please send to linux-scsi@xxxxxxxxxxxxxxx ... this is one of Martin's I
think.

James

> Cc: "James E.J. Bottomley" <JBottomley@xxxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> ---
>  drivers/scsi/sd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index efcbcd1..b54d4f8 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -296,7 +296,7 @@ protection_type_store(struct device *dev, struct device_attribute *attr,
>  	if (err)
>  		return err;
>  
> -	if (val >= 0 && val <= SD_DIF_TYPE3_PROTECTION)
> +	if (val <= SD_DIF_TYPE3_PROTECTION)
>  		sdkp->protection_type = val;
>  
>  	return count;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/