Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support

[Simon Horman]

On Thu, May 08, 2014 at 10:52:48PM +0400, Sergei Shtylyov wrote:
> On 05/08/2014 10:46 PM, Geert Uytterhoeven wrote:
> 
> >>>>>>>+               /* clocks = <&mstp3_clks R8A7740_CLK_GETHER>; */
> 
> >>>>>>      This property is mandatory, according to the bindings.
> 
> >>>>>Indeed, but you cannot put anything there until the platform has CCF, as
> >>>>>mstp3_clks doesn't exist yet.
> 
> >>>>     Yes, that was the main obstacle to accepting those bindings sooner.
> >>>>This patch therefore seems somewhat premature.
> 
> >>>My main objective is to provide working Ethernet support for Armadillo
> >>>reference now.
> 
> >>    Mine was the same (but for BOCK-W board) but DT people didn't give a
> >>damn. :-) So there's still no Ethernet support in BOCK-W DT.
> 
> >Yes there is: ethernet@18300000.
> 
>    That's for an on-board SMSC911x, not for sh_eth.
> 
> >>>The DTS already has other nodes without "clocks" properties.
> 
> >>    It means not everybody submitting the bindings had the same bad luck as me. :-)
> 
> >I think we have to be pragmatic here. The clocks properties will be added to
> >the dtsi as soon as we have CCF support.
> 
>    I'd agree, so if there's no objections from DT people, I won't object anymore.
> 

Hi Laurent, Hi Sergei,

I have queued up this series locally and I plan to push this once I have
done some testing (I am on a plane with neither internet access nor a
consignment of boards).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/