Re: [PATCH] pwm_lpss: Add support for PCI devices

[Thierry Reding]

On Mon, May 12, 2014 at 04:18:16PM -0700, Darren Hart wrote:
> On Sat, Apr 12, 2014 at 09:58:51PM +0800, Chew Chiau Ee wrote:
> > From: Alan Cox <alan@xxxxxxxxxxxxxxx>
> > 
> > Not all systems enumerate the PWM devices via ACPI. They can also be exposed
> > via the PCI interface.
> > 
> > Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
> > Signed-off-by: Chew, Chiau Ee <chiau.ee.chew@xxxxxxxxx>
> > ---
> >  drivers/pwm/pwm-lpss.c |  160 ++++++++++++++++++++++++++++++++++++++---------
> >  1 files changed, 129 insertions(+), 31 deletions(-)
[...]
> Has this landed anywhere? I didn't see it in mainline or next, am I looking in
> the wrong place?

This was applied to the pwm/for-next tree and has been in linux-next
since next-20140429.

> If it's just still pending, I ran into one issue integrating it
> with 3.14.2:
> 
>   CC [M]  drivers/pwm/pwm-lpss.o
>   drivers/pwm/pwm-lpss.c: In function âpwm_lpss_probe_pciâ:
>   drivers/pwm/pwm-lpss.c:192:2: warning: passing argument 3 of âpwm_lpss_probeâ
>   discards âconstâ qualifier from pointer target type [enabled by default]
>   drivers/pwm/pwm-lpss.c:130:30: note: expected âstruct pwm_lpss_boardinfo *â
>   but argument is of type âconst struct pwm_lpss_boardinfo *â
> 
> Can we make the third argument to pwm_lpss_probe a const? The following is
> working for me:
> 
>  static struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev,
>                                              struct resource *r,
>                                              const struct pwm_lpss_boardinfo *info)

A fix like that was applied last week and is in next-20140512.

Thierry

Attachment: pgpWvsPyoF6ul.pgp
Description: PGP signature