Re: [PATCH v8 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

[Vivek Gautam]

On Tue, May 13, 2014 at 12:13 PM, Kishon Vijay Abraham I <kishon@xxxxxx> wrote:
> Hi,
>
> On Tuesday 13 May 2014 11:37 AM, Vivek Gautam wrote:
>> Hi Kishon,
>>
>>
>> On Mon, May 12, 2014 at 6:33 PM, Kishon Vijay Abraham I <kishon@xxxxxx> wrote:
>>> Hi Gautam,
>>>
>>> On Friday 09 May 2014 07:27 PM, Vivek Gautam wrote:
>>>> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs.
>>>> The new driver uses the generic PHY framework and will interact
>>>> with DWC3 controller present on Exynos5 series of SoCs.
>>>>
>>>> Also, created a new header file in linux/mfd/syscon/ for
>>>> Exynos5 SoCs and put the required PMU offset definitions
>>>> for the basic available PHYs.
>>>>
>>>
>>>
>>> I get the following checkpatch warnings
>>>
>>> WARNING: please write a paragraph that describes the config symbol fully
>>> #163: FILE: drivers/phy/Kconfig:163:
>>> +config PHY_EXYNOS5_USBDRD
>>>
>>> WARNING: DT compatible string "samsung,exynos5250-usbdrd-phy" appears
>>> un-documented -- check ./Documentation/devicetree/bindings/
>>> #708: FILE: drivers/phy/phy-exynos5-usbdrd.c:516:
>>> +               .compatible = "samsung,exynos5250-usbdrd-phy",
>>>
>>> WARNING: DT compatible string "samsung,exynos5420-usbdrd-phy" appears
>>> un-documented -- check ./Documentation/devicetree/bindings/
>>> #711: FILE: drivers/phy/phy-exynos5-usbdrd.c:519:
>>> +               .compatible = "samsung,exynos5420-usbdrd-phy",.
>>>
>>>
>>> I think you just need to separate the Documentation into a separate patch
>>> before applying the driver patch.
>>>
>>
>> I somehow don't see the Documentation warning. Below is the checkpatch
>> output which i ran on this v8 patch version.
>>   linux-phy$ ./scripts/checkpatch.pl phy.patch
>>   WARNING: please write a paragraph that describes the config symbol fully
>>   #127: FILE: drivers/phy/Kconfig:163:
>>   +config PHY_EXYNOS5_USBDRD
>>
>>   total: 0 errors, 1 warnings, 760 lines checked
>>
>>   phy.patch has style problems, please review.
>>
>>   If any of these errors are false positives, please report
>>   them to the maintainer, see CHECKPATCH in MAINTAINERS.
>>
>> am i missing something ?
>
> Yeah.. the checkpatch.pl has got updated recently. If you use the latest kernel
> you should see it.
>

right, i can see it now with Torvald's tree. Thanks for pointing out :-)
I will move out the Documentation in a separate patch and resubmit.




-- 
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/