Re: [PATCH v1 00/11] Add Qualcomm SD Card Controller support.

[Srinivas Kandagatla]

On 13/05/14 11:04, Ulf Hansson wrote:
> On 29 April 2014 10:18,  <srinivas.kandagatla@xxxxxxxxxx> wrote:
> > From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> >
> > Hi Russell,
> >
> > This patch series adds Qualcomm SD Card Controller support in pl180 mmci
> > driver. QCom SDCC is basically a pl180, but bit more customized, some of the
> > register layouts and offsets are different to the ones mentioned in pl180
> > datasheet. The plan is to totally remove the standalone SDCC driver
> > drivers/mmc/host/msm_sdcc.* and start using generic mmci driver for all
> > Qualcomm parts, as we get chance to test on other Qcom boards.
> >
> > To start using the existing mmci driver, a fake amba id for Qualcomm is added
> > in patches:
> >   ARM: amba: Add Qualcomm vendor ID.
> >   mmc: mmci: Add Qualcomm Id to amba id table.
> >
> > Second change is, adding a 3 clock cycle delay for register writes on QCOM
> > SDCC
> > registers, which is done in patches:
> >    mmc: mmci: Add register read/write wrappers.
> >    mmc: mmci: Qcomm: Add 3 clock cycle delay after each register write
> >
> > Third change was to accommodate DATCTRL and MMCICLK register layout changes in
> > Qcom SDCC. Which is done in patches:
> >    mmc: mmci: Add Qcom datactrl register variant
> >    mmc: mmci: Add Qcom variations to MCICommand register.
> >    mmc: mmci: Qcom fix MCICLK register settings.
> >    mmc: mmci: Add clock support for Qualcomm.
> >
> > Fourth major change was to add qcom specfic pio read function, the need for
> > this is because the way MCIFIFOCNT register behaved in QCOM SDCC is very
> >   different to the one in pl180. This change is done in patch:
> >    mmc: mmci: Add Qcom specific pio_read function.
> >
> > Last some Qcom unrelated changes to support Qcom are done in patches:
> >    mmc: mmci: use NSEC_PER_SEC macro
> >    mmc: mmci: move ST specific register extensions access under condition.
> >
> > This patches are tested  v3.15-rc3 in PIO mode on IFC6410 board with both eMMC
> > and external SD card. I would appreciate any feedback on the patches.
> > I would like to get this for v3.16.
> >
> > Thanks,
> > srini
>
> Hi Srinivas,
Hi Ulf,
> Thanks for working on this patchset, much appreciated! I intend to
> review them as soon as I can.

Thats Great.
> For your information, currently there are one patch queued via Chris'
> mmc tree for mmci and recently I have added my quite extensive
> patchset, via mine mmc tree, all to be tested in Linux next.
>
> I suppose the best approach to not hit conflicts would be if you base
> your patches upon my tree. Potentially we could merge them this way,
> unless of course Russell have other opinions.
>
> git://git.linaro.org/people/ulf.hansson/mmc.git next
Makes sense, I will rebase my next version of patches on top of your mmc 
git tree, if Russell has no issues with this approach.

Thanks,
srini
> Kind regards
> Ulf Hansson
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/