Re: [PATCH] PM / OPP: discard duplicate OPP additions

[Sudeep Holla]

Hi Viresh,

On 13/05/14 12:05, Viresh Kumar wrote:
> On 13 May 2014 16:00, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
> > On Tue, May 13, 2014 at 9:22 AM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> > > On 13 May 2014 13:11, [Chander Kashyap <chander.kashyap@xxxxxxxxxx> wrote:
> > >
> > > What happened to your name ? "["
> > >
> > > > From: Chander Kashyap <k.chander@xxxxxxxxxxx>
> > > >
> > > > It may be possible to unregister and re-register the cpufreq driver.
> > > > One such example is arm big-little IKS cpufreq driver. While
> > > > re-registering the driver, same OPPs may get added again.
> > > >
> > > > This patch detects the duplicacy and discards them.
> > > >
> > > > Signed-off-by: Chander Kashyap <k.chander@xxxxxxxxxxx>
> > > > Signed-off-by: Inderpal Singh <inderpal.s@xxxxxxxxxxx>
> > > > ---
> > > >   drivers/base/power/opp.c |   28 +++++++++++++++++++---------
> > > >   1 file changed, 19 insertions(+), 9 deletions(-)
> > >
> > > I wouldn't say that this approach is particularly bad or wrong, but what
> > > about this instead?
> >
> > Yes I prefer this and this exactly what I had[1] in my OPP DT series which
> > we could not conclude on the bindings. You also need patch[2] for DT version.
>
> Ahh, I have just reinvented the wheel. Though I can see now that I have
> Acked those patches as well :)

Yes correct, it was stalled due to no discussions on the bindings.

> So, what are the plans for those patches then? As Chander also needs few
> of those.
>
> Probably split the series to get the non-blockers upstream Atleast ?

I can do that.

> Another thing that I thought later, though the problem can be fixed by
> your version of patches, the version from chander had something good as
> well. It would get rid of duplicate entries coming from dtb. Would it make
> sense to get that part in as well?

That requires agreement on the bindings. The main issue with shared opp
bindings is that in general we don't want to modify the standard bindings
without covering all aspects. It will avoid carrying around buggy bindings
forever as its ABI.

There was another thread from Samsung modifying bindings[0] and Rob insisted to
join the discussion[1] I started, but I never got any feedback.

Regards,
Sudeep

[0] http://marc.info/?l=devicetree&m=139152254008892&w=2
[1] http://www.spinics.net/lists/arm-kernel/msg303977.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/