Re: [PATCH 10/19] mm: page_alloc: Reduce number of times page_to_pfn is called

[Mel Gorman]

On Tue, May 13, 2014 at 03:27:29PM +0200, Vlastimil Babka wrote:
> On 05/13/2014 11:45 AM, Mel Gorman wrote:
> >In the free path we calculate page_to_pfn multiple times. Reduce that.
> >
> >Signed-off-by: Mel Gorman <mgorman@xxxxxxx>
> >Acked-by: Rik van Riel <riel@xxxxxxxxxx>
> 
> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
> 
> Just two comments.
> I just don't like #define but I can live with that.

page_to_pfn is not available in that context due to header dependency
problems. It can be avoided by moving the two functions into mm/internal.h
so I'll do that. I cannot see why code outside of mm/ would be missing
with those bits anyway.

Thanks

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/