Re: [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()
From: Alexander Gordeev
Date: Tue May 13 2014 - 11:19:48 EST
On Tue, May 13, 2014 at 05:01:32PM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxx>
> Cc: Matt Porter <mporter@xxxxxxxxxxxxxxxxxxx>
> Cc: Alexandre Bounine <alexandre.bounine@xxxxxxx>
I forgot to note this patch has also been
Acked-by: Alexandre Bounine <alexandre.bounine@xxxxxxx>
> Cc: linux-pci@xxxxxxxxxxxxxxx
> ---
> drivers/rapidio/devices/tsi721.c | 11 +++--------
> 1 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c
> index 1753dc6..2ca1a0b 100644
> --- a/drivers/rapidio/devices/tsi721.c
> +++ b/drivers/rapidio/devices/tsi721.c
> @@ -768,15 +768,10 @@ static int tsi721_enable_msix(struct tsi721_device *priv)
> }
> #endif /* CONFIG_RAPIDIO_DMA_ENGINE */
>
> - err = pci_enable_msix(priv->pdev, entries, ARRAY_SIZE(entries));
> + err = pci_enable_msix_exact(priv->pdev, entries, ARRAY_SIZE(entries));
> if (err) {
> - if (err > 0)
> - dev_info(&priv->pdev->dev,
> - "Only %d MSI-X vectors available, "
> - "not using MSI-X\n", err);
> - else
> - dev_err(&priv->pdev->dev,
> - "Failed to enable MSI-X (err=%d)\n", err);
> + dev_err(&priv->pdev->dev,
> + "Failed to enable MSI-X (err=%d)\n", err);
> return err;
> }
>
> --
> 1.7.7.6
>
--
Regards,
Alexander Gordeev
agordeev@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/