Re: [PATCH] vfs: add noreplace_rename2()

[Christoph Hellwig]

On Tue, May 13, 2014 at 04:43:54PM +0200, Miklos Szeredi wrote:
> There was pushback from Stephen Rothwell as well as Al, which is why it ended up
> being a separate op.

I can see some reason to not want it for an inintial merged, but having
two parallel methods in the long run is a bad design.

> I was always hoping to merge the two, but until there's clear indication that
> it's going to get accepted, there's no point in me preparing and maintaining
> such a patch.

How about we slowly work towards doing the right thing?

1) make vfs_rename call ->rename2 if it exists instead of ->rename
2) switch all filesystems that you're adding NOREPLACE support for to
   use ->rename2
3) see how many ->rename instances we'll have left after a few
   iterations of 2.

A default method implementation that just calls a slightly more
complicated version of the method is just useless clutter.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/