Re: [PATCH 1/1] fs/cifs/netmisc.c: convert printk to pr_foo()

[Joe Perches]

On Tue, 2014-05-13 at 18:10 +0200, Fabian Frederick wrote:
> Also fixes array checkpatch warning.
[]
> diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
[]
> @@ -941,8 +941,8 @@ cifs_UnixTimeToNT(struct timespec t)
>  	return (u64) t.tv_sec * 10000000 + t.tv_nsec/100 + NTFS_TIME_OFFSET;
>  }
>  
> -static int total_days_of_prev_months[] =
> -{0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334};
> +static int total_days_of_prev_months[] = {
> +	0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334};

Hi Fabian.

A preferred form for initialized array declarations is

type array[] = {
	val1, val2, ..., valn
};

Also this instance should probably be static const.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/