Re: [PATCH tip/core/rcu 32/45] torture: Better summary diagnostics for build failures

[josh]

On Tue, May 13, 2014 at 12:25:54PM -0700, Paul E. McKenney wrote:
> On Sat, May 10, 2014 at 12:34:12PM -0700, Josh Triplett wrote:
> > On Fri, May 09, 2014 at 05:48:38PM -0700, Paul E. McKenney wrote:
> > > On Wed, May 07, 2014 at 03:11:39PM -0700, josh@xxxxxxxxxxxxxxxx wrote:
> > > > On Mon, Apr 28, 2014 at 05:25:20PM -0700, Paul E. McKenney wrote:
> > > > > From: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
> > > > > 
> > > > > The reaction of kvm-recheck.sh is obscure at best, and easy to miss
> > > > > completely.  This commit therefore prints "BUG: Build failed" in the
> > > > > summary at the end of a run.
> > > > 
> > > > This commit also changes a dozen other things about the output that this
> > > > commit message does not document. :)
> > > 
> > > Well, I don't know about a dozen, but I did upgrade the commit message to
> > > read as follows:
> > > 
> > > 	The reaction of kvm-recheck.sh is obscure at best, and easy to
> > > 	miss completely.  This commit therefore prints "BUG: Build failed"
> > > 	in the summary at the end of a run.  This commit also adds the
> > > 	line of dashes in cases where performance info is not available,
> > > 	and also avoids printing nonsense diagnostics in cases where
> > > 	some of the normal test output is not available.
> > 
> > What about the change to kvm-test-1-run.sh?
> 
> Right you are!
> 
> 	The reaction of kvm-recheck.sh is obscure at best, and easy to
> 	miss completely.  This commit therefore prints "BUG: Build failed"
> 	in the summary at the end of a run.  This commit also adds the
> 	line of dashes in cases where performance info is not available,
> 	and also avoids printing nonsense diagnostics in cases where
> 	some of the normal test output is not available.  In addition,
> 	this commit saves off the .config file even when the build fails.

Looks good, ship it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/