RE: [PATCH] ARM: remove redundant code in machine_halt

[Neil Zhang]

> -----Original Message-----
> From: Neil Zhang [mailto:zhangwm@xxxxxxxxxxx]
> Sent: 2014年5月7日 13:50
> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: rmk+kernel@xxxxxxxxxxxxxxxx; Neil Zhang
> Subject: [PATCH] ARM: remove redundant code in machine_halt
> 
> There is no need to call local_irq_disable twice.
> 
> Signed-off-by: Neil Zhang <zhangwm@xxxxxxxxxxx>
> ---
>  arch/arm/kernel/process.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index
> 81ef686..18cfce4 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -195,7 +195,6 @@ void machine_halt(void)
>  	local_irq_disable();
>  	smp_send_stop();
> 
> -	local_irq_disable();
>  	while (1);
>  }
> 
> --
> 1.7.9.5

Any comments?

Best Regards,
Neil Zhang