Re: [PATCH v4] ARM: perf: save/restore pmu registers in pm notifier

[Sudeep Holla]

On 14/05/14 03:28, Neil Zhang wrote:
> > -----Original Message-----
> > From: Will Deacon [mailto:will.deacon@xxxxxxx]
> > Sent: 2014å5æ14æ 2:45
> > To: Neil Zhang
> > Cc: Sudeep Holla; 'linux@xxxxxxxxxxxxxxxx';
> > 'linux-arm-kernel@xxxxxxxxxxxxxxxxxxx'; 'linux-kernel@xxxxxxxxxxxxxxx';
> > 'devicetree@xxxxxxxxxxxxxxx'
> > Subject: Re: [PATCH v4] ARM: perf: save/restore pmu registers in pm notifier
> >
> > On Mon, May 12, 2014 at 11:22:09AM +0100, Neil Zhang wrote:
> > > > > The device tree bindings for power domains is under discussion [1]
> > > >
> > > > Thanks for the information.
> > > > But it currently for device only, core related stuff are not supported.
> > > > And is it really good to register power provider for core and let
> > > > vfp / pmu etc to get it?
> > >
> > > What's your suggestion about it?
> > > Is it OK that I add it under the PMU node?
> >
> > I don't really mind. I just want to avoid re-inventing the wheel in a
> > PMU-specific way and having to maintain that code forever because it ended
> > up in our DT description.
> >
> > Will
>
> I will prepare another patch to add DT description under PMU since there is
> no generic power domain support for pm notifier if no other concerns.
> We can change the manner if there is generic power domain support for pm notifier later.
> Thanks.

No, please don't add any DT bindings for power domains specific to PMU node.
We can't change the DT bindings once added.

As I pointed out the DT bindings for generic power domains are under discussion.
See if you can reuse it, if not help in extending it so that it can be used.

Regards,
Sudeep



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/