Re: [PATCH 1/9] ARM: STi: DT: STiH416: 416 DT Entry for clockgen A0/1/10/11/12

[Maxime Coquelin]

Hi Lee,

On 05/08/2014 10:03 AM, Lee Jones wrote:
> > > > Patch adds DT entries for clockgen A0/1/10/11/12
> > > >
> > > > Signed-off-by: Pankaj Dev <pankaj.dev@xxxxxx>
> > > > Signed-off-by: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxx>
> > > > ---
> > > >   arch/arm/boot/dts/stih416-clks.h     |  15 ++
> > >
> > > This should live in include/dt-bindings/clk
> > include/dt-bindings/clk or  include/dt-bindings/clock ?
>
> I have no idea what the difference between the two are.  I guess you
> are in a better position to answer that.  My point was just that the
> includes should be in the include directory, rather than being held
> locally in the 'dts' directory.

Even if these .h files are only used by the DTS files??

There are some .h files for pincfg related stuff, shouldn't we do the 
same in this case?

Regards,
Maxime

> > > >   arch/arm/boot/dts/stih416-clock.dtsi | 477 ++++++++++++++++++++++++++++++++++
> > > >   arch/arm/boot/dts/stih416.dtsi       |  10 +-
> > > >   3 files changed, 497 insertions(+), 5 deletions(-)
> > > >   create mode 100644 arch/arm/boot/dts/stih416-clks.h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/