Re: [PATCH 4/4] staging/wlan-ng: replace printk() with pr_xxx()

[Dan Carpenter]

On Mon, May 12, 2014 at 05:22:47PM +0200, Denis Pithon wrote:
> @@ -684,8 +685,9 @@ static int p80211knetdev_set_mac_address(netdevice_t *dev, void *addr)
>  	 * change the netdev address
>  	 */
>  	if (result != 0 || resultcode->data != P80211ENUM_resultcode_success) {
> -		printk(KERN_ERR
> -		       "Low-level driver failed dot11req_mibset(dot11MACAddress).\n");
> +		pr_err(
> +		  "Low-level driver failed dot11req_mibset(dot11MACAddress)\n"
> +		);
>  		result = -EADDRNOTAVAIL;
>  	} else {
>  		/* everything's ok, change the addr in netdev */

This is fine, but in the future, just go over the 80 character limit
instead of doing the unusual line break.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/