Re: [PATCH] dma: pl330: Add support for DMA_PAUSE command

[Jassi Brar]

On Wed, May 14, 2014 at 8:53 AM, Tushar Behera <tushar.behera@xxxxxxxxxx> wrote:
> While playing back audio, pmc_dmaengine requests the DMA channel to
> stop DMA transmission through DMA_PAUSE command.
>
> Currently PL330 driver doesn't support DMA pause command, leaving
> the DMA state inconsistent when the system resumes. Instead, it would
> be better to terminate the DMA transfer during suspend and restart
> again during resume.
>
> Tested with audio playback across a suspend-resume cycle.
>
What is pmc_dmaengine? How does DMA_PAUSE help, when there is no DMA_RESUME?

DMA_PAUSE means freezing the transfer, not dropping it. DMA_RESUME
then moves the transfer again from that point. Clubbing PAUSE with
TERMINATE is plain wrong.  Sorry.

Regards
Jassi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/