Re: [PATCH 1/2] speedstep-smi: enable interrupts when waiting

[Viresh Kumar]

On 14 May 2014 19:54, Mikulas Patocka <mpatocka@xxxxxxxxxx> wrote:
> Hi Viresh
>
> Some times ago, I sent these two cpufreq patches to fix frequency
> transition problem on speedstep-smi, but you didn't put them to the
> upstream kernel. I am resending the patches. If you would like a different
> solution to this problem, please explain it.

Probably these are just missed by Rafael. The patches are fine but the
above paragraph you wrote would get into kernel logs and must have
been placed below the three dash lines: "---"

> On Dell Latitude C600 laptop with Pentium 3 850MHz processor, the
> speedstep-smi driver sometimes loads and sometimes doesn't load with
> "change to state X failed" message.
>
> The hardware sometimes refuses to change frequency and in this case, we
> need to retry later. I found out that we need to enable interrupts while
> waiting for retry. When we enable interrupts, the hardware blockage that
> prevents frequency transition resolves and the transition is possible.
> With disabled interrupts, the blockage doesn't resolve (no matter how long
> do we wait). The exact reasons for this hardware behavior are unknown.
>
> This patch enables interrupts in the function speedstep_set_state that can
> be called with disabled interrupts. However, this function is called with
> disabled interrupts only from speedstep_get_freqs, so it shouldn't cause
> any problem.
>
> Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx
> Cc: stable@xxxxxxxxxxxxxxx
>
> ---

Here. And this will be skipped by tools (git, etc) while applying the patch.

>  drivers/cpufreq/speedstep-lib.c |    3 +++
>  drivers/cpufreq/speedstep-smi.c |   12 ++++++++++++
>  2 files changed, 15 insertions(+)

For both the patches:
Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/