Re: [PATCH] lib/crc7: Shift crc7() output left 1 bit

[Pavel Machek]

On Wed 2014-05-14 20:32:25, George Spelvin wrote:
> Pavel Machek wrote;
> > On Sun 2014-05-11 05:16:07, George Spelvin wrote:
> >> To do it properly, I have to rename all of:
> >> 
> >> crc7_syndrome_table[]
> >> crc7_byte()
> >> crc7()
> >> 
> >> even though the third is the only (in-tree) user of the first two.
> 
> > If the first two are static, there's no problem.
> 
> They're not; they're exported from the header (even though, as
> I mentioned, their only user is crc7()).
> 
> So my patch v2 1/3 renamed all three.

That's one way.

Other would be to make them static so people can't use old interfaces
by mistake.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/