Re: [PATCH 08/20] perf tools: Allow hpp fields to be sort keys

[Jiri Olsa]

On Mon, May 12, 2014 at 03:28:41PM +0900, Namhyung Kim wrote:

SNIP

> +static struct hpp_dimension hpp_sort_dimensions[] = {
> +	DIM(PERF_HPP__OVERHEAD, "overhead"),
> +	DIM(PERF_HPP__OVERHEAD_SYS, "overhead_sys"),
> +	DIM(PERF_HPP__OVERHEAD_US, "overhead_us"),
> +	DIM(PERF_HPP__OVERHEAD_GUEST_SYS, "overhead_guest_sys"),
> +	DIM(PERF_HPP__OVERHEAD_GUEST_US, "overhead_guest_us"),
> +	DIM(PERF_HPP__SAMPLES, "sample"),
> +	DIM(PERF_HPP__PERIOD, "period"),
> +};

just a nit.. overhead_guest_us|sys misplace are not properly aligned


[jolsa@krava perf]$ ./perf report -s overhead_guest_us,period,dso,sym --stdio
# To display the perf.data header info, please use --header/--header-only options.
#
# Samples: 9  of event 'cycles'
# Event count (approx.): 3808201
#
# Overhead  guest usr        Period      Shared Object                      Symbol
# ........  .........  ............  .................  ..........................
#
    43.05%     0.00%       1639423  ld-2.17.so         [.] _dl_map_object_deps   
    36.86%     0.00%       1403626  [kernel.kallsyms]  [k] _raw_spin_lock_irqsave

....


jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/