Re: [PATCH] ARM: QCOM: Enable ARM_AMBA option for Qcom SOCS.

[Kumar Gala]

On May 15, 2014, at 5:08 AM, Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> wrote:

> As some of the IPs on Qualcomm SOCs are based on ARM PrimeCell IPs.
> For example SDCC controller is PrimeCell MCI pl180. Adding this option will
> give flexibility to reuse the existing drivers as it is without major
> modifications.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> ---
> arch/arm/mach-qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig
> index a028be2..5bac591 100644
> --- a/arch/arm/mach-qcom/Kconfig
> +++ b/arch/arm/mach-qcom/Kconfig
> @@ -2,6 +2,7 @@ config ARCH_QCOM
> 	bool "Qualcomm Support" if ARCH_MULTI_V7
> 	select ARCH_REQUIRE_GPIOLIB
> 	select ARM_GIC
> +	select ARM_AMBA
> 	select CLKSRC_OF
> 	select GENERIC_CLOCKEVENTS
> 	select HAVE_SMP
> -- 
> 1.9.1

I’d rather have the driver have the select of ARM_AMBA and not the core support.  We clearly don’t need to build ARM_AMBA in to function.

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/