Re: [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X

[Felipe Balbi]

On Thu, May 15, 2014 at 02:28:46PM +0200, Ricardo Ribalda Delgado wrote:
> This patch adds support for the PLX USB3380 and USB3382.
> 
> This driver is based on the driver from the manufacturer.
> 
> Since USB338X is register compatible with NET2280, I thought that it
> would be better to include this hardware into net2280 driver.
> 
> Manufacturer's driver only supported the USB33X, did not follow the
> Kernel Style and contain some trivial errors. This patch has tried to
> address this issues.
> 
> This patch has only been tested on USB338x hardware, but the merge has
> been done trying to not affect the behaviour of NET2280.
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>

anybody with net2280, please give me a Tested-by so I'm sure there are
no regressions caused by this patch. One question though, is it worth to
use the legacy mode just to get register compatibility ? What are the
drawbacks of using legacy mode ? Is any feature missing when we use
legacy mode ?

cheers

-- 
balbi

Attachment: signature.asc
Description: Digital signature