Re: [PATCH v5 3/3] CPU hotplug, smp: Flush any pending IPI callbacks before CPU offline

[Tejun Heo]

Hello,

On Fri, May 16, 2014 at 12:44:13AM +0530, Srivatsa S. Bhat wrote:
>  /*
> + * flush_smp_call_function_queue - Flush any pending smp-call-function

Don't we need a blank line here?

> + * callbacks queued on this CPU (including those for which the source CPU's
> + * IPIs might not have been received on this CPU yet). This is invoked by a
> + * CPU about to go offline, to ensure that all pending IPI functions are run
> + * before it goes completely offline.
> + *
> + * Loop through the call_single_queue and run all the queued functions.
> + * Must be called with interrupts disabled.
> + */

Other than that, looks good to me.

Reviewed-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/