Re: [PATCH] net: tunnels - enable module autoloading

[David Miller]

From: Tom Gundersen <teg@xxxxxxx>
Date: Tue, 13 May 2014 10:48:28 +0200

> Enable the module alias hookup to allow tunnel modules to be autoloaded on demand.
> 
> This is in line with how most other netdev kinds work, and will allow userspace
> to create tunnels without having CAP_SYS_MODULE.
> 
> Signed-off-by: Tom Gundersen <teg@xxxxxxx>
> Tested-by: Susant Sahani <susant@xxxxxxxxxx>

This doesn't even compile:

  CC [M]  net/ipv4/ipip.o
In file included from include/linux/module.h:17:0,
                 from net/ipv4/ipip.c:95:
include/linux/moduleparam.h:21:1: error: expected ʽ,ʼ or ʽ;ʼ before ʽstaticʼ
 static const char __UNIQUE_ID(name)[]       \
 ^
include/linux/module.h:86:32: note: in expansion of macro ʽ__MODULE_INFOʼ
 #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
                                ^
include/linux/module.h:89:30: note: in expansion of macro ʽMODULE_INFOʼ
 #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias)
                              ^
include/linux/netdevice.h:3283:2: note: in expansion of macro ʽMODULE_ALIASʼ
  MODULE_ALIAS("netdev-" device)
  ^
net/ipv4/ipip.c:490:1: note: in expansion of macro ʽMODULE_ALIAS_NETDEVʼ
 MODULE_ALIAS_NETDEV("tunl0");
 ^