Re: [PATCH 5/9] perf, tools: Add perf download to download event files v2

[Andi Kleen]

> Could you please extend this script to support curl also?  It seems the
> wget is not installed by default on my system.

I looked at it, but it's a major pain because curl is totally
incompatible. I don't think it's a major burden to install wget?

> > +set -e
> > +
> > +if [ "$1" == "" ] ; then
> > +	S=$(awk '
> > +/^vendor/     		{ V=$3 }
> > +/^model/ && $2 == ":" 	{ M=$3 }
> > +/^cpu family/ 		{ F = $4 }
> 
> Inconsistency in using whitespace..

awk scripts always start at column 0

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/