Re: [PATCH v3 0/4] ACPICA: Cleanups for <acpi/platform/acenv.h> and <acpi/platform/aclinux.h>.
From: Rafael J. Wysocki
Date: Fri May 16 2014 - 07:49:54 EST
On Monday, May 12, 2014 03:44:37 PM Lv Zheng wrote:
> This patch series cleans up <acpi/platform/acenv.h> and
> <acpi/platform/aclinux.h>. it also fixes some mis-ordered inclusions for
> Linux resident ACPICA.
>
> There is no real issue in the Linux kernel, but this can help to cleanup
> the code so that (benefits):
> 1. Redundant environment definitions can be removed from <asm/acpi.h> and
> <acpi/platform/aclinux.h>.
> 2. Lift a burden off the ACPICA release automation - copying default ACPICA
> environment setting to all <asm/acpi.h> file each time a new environment
> is introduced just in order to avoid build errors.
> 3. The wrong <acpi/actypes.h> inclusion can be removed from
> <acpi/platform/aclinux.h>.
> 4. Using ACPICA defined types in <asm/acpi.h> is possible.
> 5. Using "static inline" to define ACPICA OSL functions is still possible
> and won't cause build errors any longer.
> 6. All non back ported prototypes are collected in a single file.
>
> The patch set has passed the following build/boot tests.
> Build tests are performed as follows:
> 1. i386 + default + COFNIG_ACPI=y
> 2. i386 + default + COFNIG_ACPI=n
> 3. x86_64 + default + COFNIG_ACPI=y
> 4. x86_64 + default + COFNIG_ACPI=n
> Boot tests are performed as follows:
> 1. i386 + default + COFNIG_ACPI=y
> 2. x86_64 + default + COFNIG_ACPI=y
> Where:
> 1. i386: machine named as "Dell Inspiron Mini 1010"
> 2. x86_64: machine named as "HP Compaq 8200 Elite SFF PC"
> 3. default: kernel configuration with following items enabled:
> All hardware drivers related to the machines of i386/x86_64
> All drivers/acpi configurations
> All platform drivers
> All ACPI drivers
> 4 DRM drivers that implement ACPI opregion
> All buses with ACPI bindings
> All cpufreq configurations
> All xen configurations
> All ACPI table drivers
>
> Lv Zheng (4):
> ACPICA: Linux headers: Remove ACPI_PREEMPTION_POINT() due to no
> usages.
> ACPICA: Linux headers: Add <acpi/platform/aclinuxex.h> to remove
> mis-ordered inclusion of <acpi/actypes.h> from
> <acpi/platform/aclinux.h>.
> ACPICA: Linux headers: Add <asm/acenv.h> to remove mis-ordered
> inclusion of <asm/acpi.h> from <acpi/platform/aclinux.h>.
> ACPICA: Cleanup redudant definitions that already have defaults in
> <acpi/platform/acenv.h>.
>
> arch/ia64/include/asm/acenv.h | 56 ++++++++++++
> arch/ia64/include/asm/acpi.h | 50 -----------
> arch/x86/include/asm/acenv.h | 49 +++++++++++
> arch/x86/include/asm/acpi.h | 45 ----------
> include/acpi/acpi.h | 4 +-
> include/acpi/platform/acenvex.h | 63 ++++++++++++++
> include/acpi/platform/aclinux.h | 171 ++++++++-----------------------------
> include/acpi/platform/aclinuxex.h | 116 +++++++++++++++++++++++++
> 8 files changed, 322 insertions(+), 232 deletions(-)
> create mode 100644 arch/ia64/include/asm/acenv.h
> create mode 100644 arch/x86/include/asm/acenv.h
> create mode 100644 include/acpi/platform/acenvex.h
> create mode 100644 include/acpi/platform/aclinuxex.h
All four applied to bleeding-edge, thanks Lv!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/