Re: [PATCH] virtio_blk: fix race between start and stop queue

[Jens Axboe]

On 2014-05-16 08:54, Christoph Hellwig wrote:
> On Fri, May 16, 2014 at 08:53:22AM -0600, Jens Axboe wrote:
> > > This patch fixes the problem by starting/stopping blk-mq
> > > with holding vq_lock.
> >
> > Why not just use blk_mq_start_hw_queues()?
>
> That would kick off a work item on every I/O completion, something
> you didn't particularly like in scsi-mq :)

It would suck, I sent a followup after that one :-)

And yes, it still needs improving in scsi-mq too.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/