Re: [PATCH v6] mm: support madvise(MADV_FREE)

[Kirill A. Shutemov]

On Fri, May 16, 2014 at 03:34:27PM +0900, Minchan Kim wrote:
> > > +static inline unsigned long lazyfree_pmd_range(struct mmu_gather *tlb,
> > > +				struct vm_area_struct *vma, pud_t *pud,
> > > +				unsigned long addr, unsigned long end)
> > > +{
> > > +	pmd_t *pmd;
> > > +	unsigned long next;
> > > +
> > > +	pmd = pmd_offset(pud, addr);
> > > +	do {
> > > +		next = pmd_addr_end(addr, end);
> > > +		if (pmd_trans_huge(*pmd))
> > > +			split_huge_page_pmd(vma, addr, pmd);
> > 
> > /* XXX */ as well? :)
> 
> You meant huge page unit lazyfree rather than 4K page unit?
> If so, I will add.

Please, free huge page if range cover it. 

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/