Re: [PATCHv2] staging: media: as102: replace custom dprintk() with dev_dbg()

[Antti Palosaari]

On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
> don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
> use the common kernel coding style.
>
> Signed-off-by: Martin Kepplinger <martink@xxxxxxxxx>

Reviewed-by: Antti Palosaari <crope@xxxxxx>

> ---
> this applies to next-20140516. any more suggestions?
> more cleanup can be done when dprintk() is completely gone.

Do you have the device? I am a bit reluctant patching that driver 
without any testing as it has happened too many times something has gone 
totally broken.

IIRC Devin said it is in staging because of style issues and nothing 
more. Is that correct?

regards
Antti

--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/