Re: [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

[Joe Perches]

On Sun, 2014-05-18 at 18:19 +0100, Masaru Nomura wrote:
> Remove prohibited space and fix line over 80 characters of
> memset(...) to meet kernel coding style.
[]
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
[]
> @@ -113,7 +113,7 @@ ksocknal_create_peer(ksock_peer_t **peerp, lnet_ni_t *ni, lnet_process_id_t id)
>  	if (peer == NULL)
>  		return -ENOMEM;
>  
> -	memset (peer, 0, sizeof (*peer));       /* NULL pointers/clear flags etc */
> +	memset(peer, 0, sizeof(*peer));     /* NULL pointers/clear flags etc */

It looks like this memset is unnecessary
as it's already zeroed by LIBCFS_ALLOC->
LIBCFS_ALLOC_GFP->LIBCFS_ALLOC_POST->memset.

It seems as if all these ALLOC macros could
use quite a bit of cleaning/sorting out.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/