Re: [PATCH] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

From: Borislav Petkov
Date: Mon May 19 2014 - 03:26:55 EST


On Mon, May 19, 2014 at 09:55:40AM +0800, Chen Yucong wrote:
> But all other CPUs also have to wait monarch CPU to exit from mce_end.
> What's the difference between monarch CPU and Per-CPU for clearing
> mces_seen? In practice, there is no difference between them. If we use
> monarch CPU to clear mces_seen, then Per-CPU variable can not play out
> its advantage.

I'll let you stare at mce_reign() a little bit longer... Also, pay
attention to its callsite, that might help.

> Well, in that case, why is there a need for time-out machine in MCE
> handler?

I'll let you figure this out yourself too - it is only fair.

:-)

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/