Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

[Dan Carpenter]

On Sun, May 18, 2014 at 07:39:23AM +0100, Karim Raslan wrote:
> This should fix a few sparse warnings like the following:
> 
>   CHECK   drivers/staging/rtl8723au/core/rtw_ap.c
> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45: warning: incorrect type in argument 3 (different base types)
> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45:    expected int [signed] gfp
> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45:    got restricted gfp_t
> 

Thanks, Karim, looks good.

Jes's patch which added this never went to the list so I didn't review
it.  This annoys me.

I try to be fair when I review code.  I try to allow lots of patches in
and let people send fix up patches for minor stuff.  But, obviously, you
should be running Sparse as part of the review process so if I made you
redo this patch it's because your process is broken.  When I review
patches I am trying to help you.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/