Re: [PATCH 3/5] usb: gadget: net2280: Use BIT() macro

[Ricardo Ribalda Delgado]

Hello David

I dont want to start a flame war here :) but  In the particular case
of hardware registers I believe it does.

This patch has been posted because on a previous patch to support the
usb3380, one of the requested changes was to use this macro. In order
to have consistent code in the file I have posted this patch.

BTW, I havent defined the bit macro, just used it :P

Cheers!


On Mon, May 19, 2014 at 12:18 PM, David Laight <David.Laight@xxxxxxxxxx> wrote:
> From: Ricardo Ribalda Delgado
>> Improves readability of the code
>
> Personally I don't find macros like BIT() improve the readability at all.
> What next? Maybe:
>
> #define ADD(a, b) ((a) + (b))
>
>         David
>
>
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/